Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special printing of DomainError broken by #14815 #14985

Closed
tkelman opened this issue Feb 8, 2016 · 2 comments
Closed

Special printing of DomainError broken by #14815 #14985

tkelman opened this issue Feb 8, 2016 · 2 comments
Labels
error handling Handling of exceptions by Julia or the user

Comments

@tkelman
Copy link
Contributor

tkelman commented Feb 8, 2016

and not tested carefully enough, apparently

  | | |_| | | | (_| |  |  Version 0.5.0-dev+2532 (2016-02-08 03:26 UTC)
 _/ |\__'_|_|_|\__'_|  |  Commit 019c4d1* (0 days old master)
|__/                   |  x86_64-linux-gnu

julia> sqrt(-1)
ERROR: DomainError:SYSTEM: show(lasterr) caused an error

since lookup is not defined here

julia/base/replutil.jl

Line 127 in 019c4d1

if code !== lookup && code.from_c

@tkelman tkelman added the error handling Handling of exceptions by Julia or the user label Feb 8, 2016
@vtjnash
Copy link
Member

vtjnash commented Feb 8, 2016

fixed (and tested) in 69f7571

@vtjnash vtjnash closed this as completed Feb 8, 2016
@tkelman
Copy link
Contributor Author

tkelman commented Feb 8, 2016

Great! Those don't all pass on Windows or Linux though.

@tkelman tkelman mentioned this issue Feb 8, 2016
Closed
@tkelman tkelman mentioned this issue Feb 23, 2016
Closed
@yuyichao yuyichao mentioned this issue Mar 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
error handling Handling of exceptions by Julia or the user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vtjnash @tkelman