Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creator: Revenue Share history widget #3848

Closed
1 task
Tracked by #3384 ...
dmtrjsg opened this issue Feb 17, 2023 · 3 comments
Closed
1 task
Tracked by #3384 ...

Creator: Revenue Share history widget #3848

dmtrjsg opened this issue Feb 17, 2023 · 3 comments
Labels
creator-token Creator tokens

Comments

@dmtrjsg
Copy link

dmtrjsg commented Feb 17, 2023

Context

Scope

  • Revenue share history widget

Not showing during very first sale
Shows for all other ones

Design

LInk to Figma>

Screenshot 2023-02-17 at 14 50 46

@dmtrjsg dmtrjsg mentioned this issue Feb 17, 2023
79 tasks
@dmtrjsg dmtrjsg added the creator-token Creator tokens label Feb 17, 2023
@dmtrjsg dmtrjsg closed this as completed Nov 16, 2023
@dmtrjsg dmtrjsg mentioned this issue Nov 16, 2023
47 tasks
@polikosi
Copy link
Collaborator

polikosi commented Dec 6, 2023

All holders - 3
participant in first - 1 holders (it's me - owner tokens)
participant in second - 0 holders
I don't see the percentage and number of all owners
image

@polikosi polikosi mentioned this issue Dec 6, 2023
35 tasks
@WRadoslaw
Copy link
Contributor

All holders - 3 participant in first - 1 holders (it's me - owner tokens) participant in second - 0 holders I don't see the percentage and number of all owners image

This is Orion issue, we don't know the number of token holders at a specific time in the past, so we will need to introduce some logic to add this number to the revenue share entity, but the problem will be scheduling this, since ppl can join till the end of the revenue share and there is no runtime event that would trigger it, so we either can introduce some scheduling (more work) or check holders number at the time of finalizing the share by the owner (it will include an error of ppl that got the token after end time, but before finalizing). cc @bedeho @ignazio-bovo

@WRadoslaw WRadoslaw reopened this Dec 7, 2023
@WRadoslaw WRadoslaw mentioned this issue Dec 11, 2023
9 tasks
@polikosi
Copy link
Collaborator

a somewhat strange calculation of the total number of tokens and the number of tokens that have been claimed by holders.
Holders have been claimed onlu 178 tokens.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
creator-token Creator tokens
Projects
None yet
Development

No branches or pull requests

3 participants