Added big generation value parsing #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In the XREF section, with generation values greater than 65535 (2¹⁶) the parsing process fails because it expects u16 but the value does not fit. This is very unlikely to happen but I found many PDF generated with this poblem (I attach one example).
In all cases, just ignoring these entries was a valid solution and this is why I just changed the process at parsing level allowing u32 and then converting it to u16 so everything else runs as before.
With this simple change the library is a little more robust by not failing at these weird cases.
DOC2018082312575338+18+INFORME+NECESIDAD.pdf