Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make xref public ,fix line endings and Fix Xref output so Adobe will open them again. #181

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Conversation

genusistimelord
Copy link

This will make Xref public which should be done since it is a pub type within document. This also allows users to set the cross_reference_type.

Also fixed some line endings that git decided to change to windows style. Sorry about that.

@genusistimelord
Copy link
Author

genusistimelord commented Jul 29, 2022

@J-F-Liu and @ralpha Can you please make sure the fixes i made towards the Xref Stream work for your PDF's as well. As the current XRef stream was not using FlateDecode so removing that Filter and Adding in the /Type /XRef has fixed the stream style issue for me. This was based on what I had found in the https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/pdfreference1.5_v6.pdf reference book and while looking at other already made PDF of Version 1.5 thru 1.7.

If we do want to use the Filter then we also need to encode the Stream as FlateDecode and update and add the ability to choose what Stream Filter we want to use in the Config.

The changes should Fully fix #180

@genusistimelord genusistimelord changed the title Make xref public and fix line endings that got changed by git Make xref public ,fix line endings and Fix Xref output so Adobe will open them again. Jul 29, 2022
@J-F-Liu J-F-Liu merged commit 6b04581 into J-F-Liu:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants