Fix document save race in parser_aux::load_and_save and creator::create_document #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the race condition identified in issue 137:
#137
There were several changes to fix the existing code and make adding new tests that create files more safe:
Make public helper functions to create and remove documents that can be called from other tests.
Put those helpers and the other unit tests in a tests namespace to make it clear they're for testing.
Use different filenames in different file tests (parser_aux and creator).
In creator, add a mutex around saving and reading files with the same filename.
Let me know if there are any questions or if you have any changes.
Thanks for the great work on this project.