Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect version tag displayed when running SHARPy #61

Closed
ngoiz opened this issue Dec 17, 2019 · 0 comments
Closed

Incorrect version tag displayed when running SHARPy #61

ngoiz opened this issue Dec 17, 2019 · 0 comments

Comments

@ngoiz
Copy link
Contributor

ngoiz commented Dec 17, 2019

The version tags we have been using are lightweight tags and, hence, when running

def get_git_tag(di=sharpydir.SharpyDir):
    return subprocess.check_output(['git', 'describe'], cwd=di).strip().decode('utf-8')

it returns v0.1 instead of the correct version.

For future releases we need to ensure the tags are annotated tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant