Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Single Page Onboarding set to Continue #174

Closed
jbmaruh opened this issue Aug 1, 2023 · 0 comments · Fixed by #183 or #184
Closed

[BUG] Single Page Onboarding set to Continue #174

jbmaruh opened this issue Aug 1, 2023 · 0 comments · Fixed by #183 or #184
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jbmaruh
Copy link

jbmaruh commented Aug 1, 2023

Describe the bug
When utilizing Onboarding with a singular page the primary button maintains the "Continue" state rather than the "Close" state.

To Reproduce
Steps to reproduce the behavior:

Trigger an Onboarding UI with a single page using the example invocation, or any other:
~/Applications/IBM\ Notifier.app/Contents/MacOS/IBM\ Notifier -type onboarding -payload "{\"pages\":[{\"title\":\"First page's title\",\"subtitle\":\"First page's subtitle\",\"body\":\"First page's body\"}]}"

Screenshot 2023-08-01 at 8 09 25 AM

Expected behavior
Expected to appear by default as if the primaryButtonLabel is set to close.
~/Applications/IBM\ Notifier.app/Contents/MacOS/IBM\ Notifier -type onboarding -payload "{\"pages\":[{\"title\":\"First page's title\",\"subtitle\":\"First page's subtitle\",\"body\":\"First page's body\",\"primaryButtonLabel\":\"Close\"}]}"

Screenshot 2023-08-01 at 8 09 30 AM

This bug does not occur when the pages are two or greater and correctly shows the Continue button until the last page is reached, which then reverts to Close.

Desktop (please complete the following information):

  • OS: macOS Ventura 13.5, macOS Ventura 13.4.1, macOS Sonoma B4
  • Project version: 3.0.0 B104

Workaround:
Add "primaryButtonLabel":"Close" to the page creation for a singular page deployments.

@jbmaruh jbmaruh added the bug Something isn't working label Aug 1, 2023
@SMartorelli SMartorelli added this to the Version 3.1.0 milestone Aug 1, 2023
@SMartorelli SMartorelli self-assigned this Aug 1, 2023
@SMartorelli SMartorelli mentioned this issue Sep 5, 2023
6 tasks
@SMartorelli SMartorelli linked a pull request Sep 5, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants