Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: schema added support for cases where schemas name contains '.' #57

Merged
merged 3 commits into from
Aug 13, 2021
Merged

fix: schema added support for cases where schemas name contains '.' #57

merged 3 commits into from
Aug 13, 2021

Conversation

Himenon
Copy link
Owner

@Himenon Himenon commented Aug 13, 2021

Summary

Support

components:
  schemas:
    Book.Author:  # <--- Support!
      type: object
      required:
        - id
        - name
      properties:
        id:
          type: string
        name:
          type: string
          description: author name

Test Plan

Himenon
Himenon commented Aug 13, 2021
View reviewed changes
src/internal/OpenApiTools/components/Schemas.ts
@@ -81,7 +81,7 @@ export const generateNamespace = (
name: convertContext.escapeDeclarationText(name),
comment: reference.data.description,
type: factory.TypeReferenceNode.create({
name: convertContext.escapeDeclarationText(context.resolveReferencePath(currentPoint, reference.path).name),
name: convertContext.escapeReferenceDeclarationText(context.resolveReferencePath(currentPoint, reference.path).name),
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: escapeが二重にかかっているのでシンプルにする

src/internal/OpenApiTools/components/Schemas.ts
@@ -53,7 +53,7 @@ export const generateNamespace = (
export: true,
name: convertContext.escapeDeclarationText(name),
type: factory.TypeReferenceNode.create({
name: convertContext.escapeDeclarationText(maybeResolvedName),
name: convertContext.escapeReferenceDeclarationText(maybeResolvedName),
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: escapeが二重にかかっているのでシンプルにする

@Himenon Himenon changed the title fix: added support for cases where schemas name contains fix: schema added support for cases where schemas name contains '.' Aug 13, 2021
@Himenon Himenon merged commit 7502673 into main Aug 13, 2021
@Himenon Himenon deleted the fix/support-dot-schema-name branch August 13, 2021 04:43
@Himenon Himenon mentioned this pull request Aug 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Himenon