Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React does not recognize the XXX prop on a DOM #153

Closed
maxfarseer opened this issue Apr 11, 2018 · 6 comments
Closed

React does not recognize the XXX prop on a DOM #153

maxfarseer opened this issue Apr 11, 2018 · 6 comments

Comments

@maxfarseer
Copy link

I'm using recyclerlistview with react-native-web, and have a lot of this warnings in development mode. How it's possible to get rid of it?

@naqvitalha
Copy link
Collaborator

@necolas Shouldn't RNW ScrollView filter out the props it doesn't understand? The react-native one does. Regardless, I plan to filter these out in RLV itself in a future revision.

@necolas
Copy link

necolas commented Apr 11, 2018

Yeah I kind of hate how sloppy RN is about passing props down. It should be more explicit and not pass everything through.

@naqvitalha
Copy link
Collaborator

It does so before sending them down to the native views. So, it works out in this case. RNW isn't doing so. Although I plan to filter out at RLV level. But should we think about making RNW somewhat selective while choosing props to pass down to inner div?

@necolas
Copy link

necolas commented Apr 11, 2018

Possibly, but filtering props isn't free and should really be taken care of in user land components. Passing invalid props to RN components should be prop warnings and flow errors. Like RN FlatList passes all it's props to scrollview even though they are not recognized :/

@naqvitalha
Copy link
Collaborator

Exactly, so you suggest we do it at the List level then?

@cgav
Copy link

cgav commented May 24, 2018

@naqvitalha @necolas any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants