Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract caret #430

Closed
wants to merge 13 commits into from
Closed

Extract caret #430

wants to merge 13 commits into from

Conversation

JordanMartinez
Copy link
Contributor

WIP

@JordanMartinez
Extract EMPTY_RANGE and clamp() to utilities class
995d775 
- These are used throughout the project and are stand-alone. This reduces code duplication
@JordanMartinez
Extract caret and selection-related model into CaretSelectionModel …
5881a03 
…class.

- Renamed `currentParagraph` to `caretParagraph` as this will eventually allow multiple carets/selections to be used.
@JordanMartinez
Make class public
4bab903
@JordanMartinez
Remove Supplier: not necessary
7f6b843
@JordanMartinez
Extract caretDirty into caret selection model
8d079e8
@JordanMartinez
Add getter to caret selection model
0d6fe87
@JordanMartinez
Add eventstream for selection dirty events
da2c345
@JordanMartinez
Extract caret and selection-related view into CaretSelectionView cl…
86bdda0 
…ass.
@JordanMartinez
Move javadoc to where it should reside
d432ac5
@JordanMartinez
Make base area use CaretSelectionView
5dde687
@JordanMartinez
Minor fix: update to use Utilities Empty_Range
4900eab
@JordanMartinez
Implement Selection interface
0ab87f6
@JordanMartinez
Add getter to selection
9b340c3
@JordanMartinez JordanMartinez mentioned this pull request Jan 18, 2017
Closed
@JordanMartinez
Copy link
Contributor Author

Still to do:

  • implement a proper getSelectionBoundsFor(CaretSelectionView)
  • include CaretOffsetX

@JordanMartinez
Copy link
Contributor Author

Closing because this should be reimplemented in a different way now that #463 has been merged.

@JordanMartinez JordanMartinez deleted the extractCaret branch April 15, 2017 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JordanMartinez