Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix avoidance behaviour, add wall avoidance, enforce min speed, sensi… #739

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Fix avoidance behaviour, add wall avoidance, enforce min speed, sensi… #739

merged 2 commits into from
Dec 8, 2021

Conversation

MILeach
Copy link
Collaborator

@MILeach MILeach commented Nov 30, 2021

…ble params

ptheywood
ptheywood reviewed Nov 30, 2021
View reviewed changes
examples/boids_spatial3D/src/main.cu Show resolved Hide resolved
examples/boids_spatial3D/src/main.cu Show resolved Hide resolved
examples/boids_spatial3D/src/main.cu Outdated Show resolved Hide resolved
examples/boids_spatial3D/src/main.cu Outdated Show resolved Hide resolved
@Robadob
Copy link
Member

Robadob commented Dec 1, 2021

You rly need to rebase this branch against the force pushed master. Super hard to make sense of the diff (I was trying to check if you'd updated all of the boids examples).

@MILeach MILeach marked this pull request as ready for review December 7, 2021 22:46
Robadob
Robadob approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@Robadob Robadob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I haven't personally built/ran the code.

ptheywood
ptheywood requested changes Dec 8, 2021
View reviewed changes
Copy link
Member

@ptheywood ptheywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id_t should be used for the results of getID().

Otherwise behaviour looks good from visualisations.

I'm still keen for the dependency_graph example to be folded in, but that can wait.

examples/swig_boids_spatial3D/boids_spatial3D.py Outdated Show resolved Hide resolved
@Robadob
Copy link
Member

Robadob commented Dec 8, 2021

This will need to be squash merged.

@Robadob Robadob merged commit 5b693d7 into master Dec 8, 2021
@Robadob Robadob deleted the boids-fix branch December 8, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robadob Robadob Robadob approved these changes

@ptheywood ptheywood ptheywood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MILeach @Robadob @ptheywood