Bugfix macroprop arithmetic operator overloads shouldn't change the macroprop #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robadob
force-pushed
the
bugfix_macroprop_artihmetic
branch
from
4d1e461 to
59f1291
Compare
When using operator+() and operator-() on MacroProperties, the value of the macro property would be mutated. This has now been resolved, and tests updated, to confirm the value of the MacroProperty is unchanged.
Robadob
force-pushed
the
bugfix_macroprop_artihmetic
branch
from
59f1291 to
5a11d56
Compare
MILeach
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the updated tests now pass (windows/debug), and initially failed.
Have checked the user guide and it doesn't need updating, it only discusses type limitations for the none overloaded fns (min, max etc).