Bugfix, logging variable mean for an empty agent pop #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robadob
commented
Nov 16, 2021
| for (auto& step : sl) { // Check step log doesn't contain NaN | ||
| EXPECT_EQ(step.getAgent(AGENT_NAME1).getMean("float_var"), 0.0); | ||
| } | ||
| } |
There was a problem hiding this comment.
Note, I didn't put test at the end of the file, in hopes of avoiding a conflict with my other logging pr.
ptheywood
approved these changes
Nov 16, 2021
would lead to a result of NaN, which JSON exported as empty string (invalid JSON). Also adds a simple test which checks the result is 0.
Robadob
force-pushed
the
bugfix_logging_mean_nan
branch
from
f1ea2e7 to
9e401a3
Compare
|
Added an explicit flush to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
would lead to a result of NaN, which JSON exported as empty string (invalid JSON).
Also adds a simple test which checks the result is 0.