Bugfix: CUDAEnsemble would always output both step/exit files. #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robadob
force-pushed
the
bugfix_ensemble_alwaysexport
branch
from
7553b4b to
99d306c
Compare
If output directory specified, even if no logging config.
Robadob
force-pushed
the
bugfix_ensemble_alwaysexport
branch
from
99d306c to
849c8dc
Compare
ptheywood
approved these changes
Oct 29, 2021
|
I'm not in a rush for this one to be merged, so I might amend it later. |
|
The main reason I promoted it to an issue rather than asking for a fix sooner is that when we drop C++14 using |
|
Have added an extra commit which addresses #731, the new tests all pass locally (on Windows). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minor bug. If a user requests step log files from a
CUDAEnsemble, basically empty exit log files would always be created too. I presume the opposite is also true (or rather specifying an output dir gets you log files).Closes #731