-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUDAEnsemble / RunPlan / RunPlanVector tests #656
Comments
Potential issues to ensure there are test for, as highligthed by JP (snippets written by me so may not be exact match): Set seeds on RunPlans and maybe elsewhere appear to only support little numbers that fit int vec = pyflamegpu.RunPlanVector()
# This is a > 32 bit value, so will need a type specialised version of setSeed, or make it take 64 bit values all the time which is likely the better choice.
x = 4628484339127465486
vec.setRandomSimulationSeed(x)
# OverflowError: in method 'RunPlan_setRandomSimulationSeed', argument 2 of type 'unsigned int'
Calling |
re: Random seeds of more than 32 bits: CuRAND accepts The current host rand implementation uses This should address the seed type issue in python, but will require changes throughout many files where seeds are currently considered |
Have now confirmed that there are issues with:
|
Testing of
CUDAEnsembles
and related features is sparse / missing, with minor coverage provided in thetest_logging
files for each interface.Some functions such as
setRandomSimulationSeed
do not appear in either test suite.The text was updated successfully, but these errors were encountered: