Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

Test with Angular v1.6.0+ (master branch) #319

Closed
jwasilgeo opened this issue Dec 26, 2016 · 0 comments · Fixed by #320
Closed

Test with Angular v1.6.0+ (master branch) #319

jwasilgeo opened this issue Dec 26, 2016 · 0 comments · Fixed by #320
Assignees
@jwasilgeo
Labels
tests

Comments

@jwasilgeo
Copy link
Contributor

jwasilgeo commented Dec 26, 2016 •
edited
Loading

Related to #314. This issue is for the master (v2) angular-esri-map branch.

e2e functional tests will go over a suite of Angular pre-v1.6.0 (ONCE) and Angular v1.6.0+ to make sure any controller code changes to support the $compile's $onInit() work for older and newer Angular versions.

See here and the part about:

If you are writing a library, you need to change your code as shown above. Furthermore, if your library also targets versions before 1.5 (which do not support the $onInit() lifecycle hook), you may need to manually call $onInit() from your constructor...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jwasilgeo jwasilgeo

Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

314 angular 1.6.0 view options Esri/angular-esri-map
1 participant
@jwasilgeo