Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

New sample page for Bookmarks (v2beta2) #212

Closed
4 tasks done
jwasilgeo opened this issue Jan 21, 2016 · 4 comments · Fixed by #223
Closed
4 tasks done

New sample page for Bookmarks (v2beta2) #212

jwasilgeo opened this issue Jan 21, 2016 · 4 comments · Fixed by #223
Assignees
Milestone

Comments

@jwasilgeo
Copy link
Contributor

Create a new sample page for bookmarks

This should ideally include:

  • test page
  • functional tests
  • example page in the gh-pages site
  • deal with info in comment below

Originates from #194.

@jwasilgeo jwasilgeo self-assigned this Jan 21, 2016
@jwasilgeo jwasilgeo added this to the v2-beta.2 milestone Jan 21, 2016
@jwasilgeo
Copy link
Contributor Author

Functional tests have been written, but sometimes the webscene slides demo just doesn't load (both as a test page or within the gh-pages site). Not sure if maybe setting the self.map property is within the angular digest cycle, which the <esri-scene-view> depends on to happen.

  • More investigation is needed before finishing this issue.

@jwasilgeo
Copy link
Contributor Author

See 12cb742

@jwasilgeo
Copy link
Contributor Author

@tomwayson in continuing to use $scope.$appy(), I encountered a few times when scope was attempting to be applied when the digest cycle was already running, erroring the app or a sample page out. Digging around some more online actually has led me to start trying to use $scope.$evalAsync.

Some more here:
angular/angular.js#2023, which led me to
https://groups.google.com/d/msg/angular/iXnA80JOZUg/PYD6KWjNbwkJ

See 6ff1fd4

@tomwayson
Copy link
Member

I've been thinking the $scope.$apply() issues we've been having are symptoms of larger problems, so I'm not real keen on $scope.$evalAsync as the solution. I've started on trying to diagnose the root causes and propose some fixes.

First, I noticed #219. Until we figure out what to do about that, it's probably safest to use the promise form of esriLoader.require() when experiencing async/digest weirdness.

Next, the call to $sccope.$apply() w/in the view.then() here makes sense, but it's inconsistent w/ the way the v1 map directive's load event worked. So I'm proposing the changes in #220.

@jwasil, please review #219 and #220 and let's have a pow-wow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants