-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I have officially spent four hours of my lifespan to set a color theme. #510
Comments
Also I am fully volunteer to write documentations for “how-to-do X” outside of full demos, but even internal code is too complex for me to navigate. |
Ahah there's a lot of concerns here. I am aware that this is a really complex library to use. You have no idea how much time was spent to make it no more complicated than what it already is. I agree documentation is lacking, but it's also big enough to scare any newcomer, so I'm not sure how to document it properly.
A VScode extension is not a new concept, it's ... a VSCode extension, like one you can install in your VSCode. There are multiple ways of installing it with this library:
That errors happens a lot, because the library make use a lot of the That's probably also the cause of the missing labels The error is quite misleading though, because the extension file are loaded through a virtual filesystem implementation that transform extension-file urls to real urls imported using your bundler, and the loading error only mention the extension-file url. Also, there is only a single demo for everything that became really complex. We probably need simpler demos of various supported features now |
Thank you so much for extensive response @CGNonofr, everything works like a charm after configuring Vite, syntax highlighter, themes, workers etc. everything was broken but its working wonderful now. By the way, I am so sorry if I sounded too aggressive initially. Thank you again <3 |
Feel free to suggest any change in the documentation that would have make the onboarding simpler for you though! |
Sure, I will try to contribute as much as I can to the examples and documentation ( after i learn inside outs ofc ) |
Preface, I am not saying that "your library is shit", both packages/foundations are a godsend, they are perfect for an all-in-one batteries included Monaco setup. Both libs together creates a new level above Monaco, making a high-level structure and this is awesome! Idea of "plug-in monaco setup" sounds awesome, implementation is awesome, everything about it is awesome. Except using it. Entry barrier is higher than Mount Everest, entire thing sets a new level of complexity, documentation is severely lacking to a non existent. Using both libraries for the first time is insanely hard, harder than Haskell, harder than writing a HTTP server in COBOL.
I have a theme. /~https://github.com/sainnhe/gruvbox-material-vscode/blob/master/themes/gruvbox-material-dark.json. A VSCode theme. What is the sane way to use it? Throw it to https://vsctim.vercel.app/, then get the Monaco editor compatible JSON,
then
bing, right?
hmmm, lets look at the issue. #458 okay, that makes sense, I have set theme services
but...
uhhhhhhhhhhhh what? what vscode extension? I have a berlin wall of
package.json
what do you mean by VSCode extension?but okay, I can live with default themes.
hmm... there is something wrong... it looks like labels are not loaded...
loadThemes
is set to True inmonaco-editor-wrapper.WrapperConfig
. so whenmonaco-editor-wrapper
initializes, I also import the default extension.makes sense! lets set our theme
...what?
there is default themes under the
@codingame/monaco-vscode-theme-defaults-default-extension
so what is wrong? where am I supposed to look at? what is going on here? where should I take reference? custom color themes does not work, default colors does not work, there is no documentation for it, what am I supposed to do here?WrapperConfig
Monaco
package.json
any help is appreciated, because there is no other resources to be found.
edit: I dont know why WrapperConfig is rendered as 4 space, sorry for that infinite blackhole.
The text was updated successfully, but these errors were encountered: