-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(carousel): add shadow on hover #308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Increase the ::before ::after width to around 9%
- Implement Pause of Carousel when user hovers on an item
The tests are failing because of coverage threshold. I'll update the tests now. Meanwhile @kaushiknishchay and @KRRISH96 can review the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pauseOnHover
seems ineffective after clicking one of next or prev buttons.
Fixed in 97f5c0f |
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Status :
Ready
Description :
Add shadow to increase button visibility
Related Issues :
#287
Todos