Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(carousel): add shadow on hover #308

Merged
merged 5 commits into from
Jan 3, 2019
Merged

Conversation

rishichawda
Copy link
Contributor

Status :

Ready

Description :

Add shadow to increase button visibility

Related Issues :

#287

Todos

  • Tests
  • Documentation

Copy link
Contributor

@kaushiknishchay kaushiknishchay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Increase the ::before ::after width to around 9%
  • Implement Pause of Carousel when user hovers on an item

@rishichawda
Copy link
Contributor Author

rishichawda commented Jan 3, 2019

The tests are failing because of coverage threshold. I'll update the tests now. Meanwhile @kaushiknishchay and @KRRISH96 can review the code.

kaushiknishchay
kaushiknishchay previously approved these changes Jan 3, 2019
Copy link
Contributor

@KRRISH96 KRRISH96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pauseOnHover seems ineffective after clicking one of next or prev buttons.

@rishichawda
Copy link
Contributor Author

The pauseOnHover seems ineffective after clicking one of next or prev buttons.

Fixed in 97f5c0f

KRRISH96
KRRISH96 previously approved these changes Jan 3, 2019
@rishichawda rishichawda merged commit 1186067 into development Jan 3, 2019
@rishichawda rishichawda deleted the carousel-design-update branch January 3, 2019 07:54
@rishichawda
Copy link
Contributor Author

🎉 This PR is included in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants