Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing bootstrap-timepicker? #5127

Closed
ChurchCRMBugReport opened this issue Jan 15, 2020 · 5 comments
Closed

Missing bootstrap-timepicker? #5127

ChurchCRMBugReport opened this issue Jan 15, 2020 · 5 comments

Comments

@ChurchCRMBugReport
Copy link

Logged in with admin, on initial load of dashboard, observed in console:

GET https://example.com/skin/external/bootstrap-timepicker/bootstrap-timepicker.min.css net::ERR_ABORTED 404 (Not Found)

GET https://example.com/skin/external/bootstrap-timepicker/bootstrap-timepicker.min.js net::ERR_ABORTED 404 (Not Found)
Collected Value Title Data
Page Name /Menu.php
Screen Size 1080x1920
Window Size 882x1159
Page Size 2973x1159
Platform Information Linux thomas-fitzsimmons 4.14.117-grsec-grsec+ #1 SMP Sat May 11 00:40:24 UTC 2019 x86_64
PHP Version 7.3.11
SQL Version 5.7.25-log
ChurchCRM Version 3.5.5
Reporting Browser Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.117 Safari/537.36
Prerequisite Status All Prerequisites met
Integrity check status {"status":"success"}
@brimarq
Copy link

brimarq commented Jan 15, 2020

Looks like bootstrap-timepicker was left out of the dependencies?

@brimarq
Copy link

brimarq commented Jan 15, 2020

Run this from the churchcrm root directory as a temporary fix?

(mkdir -m 755 ./skin/external/bootstrap-timepicker && cd "$_" && \
wget https://unpkg.com/bootstrap-timepicker@0.5.2/{'css/bootstrap-timepicker.min.css','js/bootstrap-timepicker.min.js'} && \
chmod 644 ./bootstrap-timepicker.min.*)

@crossan007
Copy link
Contributor

crossan007 commented Jan 24, 2020

It looks like we don't actually use this package anymore (as of approximately 2760795)

Were you able to observe anything broken (other than the 404 in your browser logs)?

@crossan007
Copy link
Contributor

This is closed by 0d694a5

and will be fixed in 4.0.0

@brimarq
Copy link

brimarq commented Jan 26, 2020

It looks like we don't actually use this package anymore (as of approximately 2760795)

Were you able to observe anything broken (other than the 404 in your browser logs)?

No, just the console 404s. I figured that it was likely leftover code from an intentionally removed package; but, I figured it couldn't hurt to manually add it from unpkg just in case. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants