-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement our runtime with github.com/tetratelabs/wazero #2585
Comments
Should this replace #1268? |
What do you think @timwu20 ? Personally I would rather have a single Go runtime to throw out CGO, but we could also have different binaries/different build tags to have a fully Go version and a CGO one. 🤔 |
What is the benefit of offering both options? When would someone ever want to select the CGO option? |
I'd say it's unclear for now, but maybe one runtime uses less or more resources. I'd say we can take the decision to 'prune' wasmer once wazero is implemented if it's superior/close enough in terms of performance. |
ooops put our notes on the wrong issue #2749 (comment) ps we owe a huge page on the issues on CGO, though not all are obvious at first. Some will want to avoid it for docker alone, not just smaller but a lot simpler vs tracking shared libs etc https://gist.github.com/codefromthecrypt/edb33284354d592dc6056b9b7263872f |
Thanks @codefromthecrypt Not only wasmer/cgo has production disadvantages, but it's also a pain in terms of development (notably unreadable panic messages instead of native Go panics when a Go nil pointer not even touching CGO is dereferenced, devs are forced to use glibc OSes with C libraries). Anyway hoping to do this migration soon! #2749 got merged so one step closer! 👍 |
🎉 This issue has been resolved in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Task summary
lib/runtime
lib/runtime/wasmer
implementationThis is likely at least one week of work since all the code lib/runtime has to be modified, and tests adapted to work with wazero without cgo.
Outcomes
unknown pc pointer
stack tracesOther information and links
The text was updated successfully, but these errors were encountered: