Fix iterator invalidation bug #5001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrineau
requested changes
Sep 17, 2020
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/repair_degeneracies.h
Outdated
Show resolved
Hide resolved
lrineau
approved these changes
Sep 17, 2020
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/repair_degeneracies.h
Outdated
Show resolved
Hide resolved
…epair_degeneracies.h Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
MaelRL
added
the
Not yet approved
MaelRL
added
Replaced
and removed
Not yet approved
|
Thank you for the bug report. I have rewritten the full loop in #5012 to be less intricate (but without copying anything), which should fix your issue. Could you please test it on your data set? I would also be interested if you could please share it, degeneracy removal is still quite WIP, and I do not have non-trivial data for this particular configuration. |
|
I tried and it does work now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
There is an iterator invalidation bug when looping over
degenerate_face_setand modifying it at the same time (see this page on cppreference for details on iterator invalidation).On some meshes it can causes segmentation faults. If required I can upload a .off file containing a mesh for which it's the case (but I don't have a minimal example, only a 156K .off file).
I fix that by simply iterating over a copy of
degenerate_face_setrather than the original one (while still modifying the original one). It might not be the most computationally efficient way to do it (it involves creating a copy of the set), but it does fix the bug in one line of code.Release Management