Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_hexahedron order of template parameters #8362

Closed
afabri opened this issue Jul 19, 2024 · 2 comments · Fixed by #8366
Closed

make_hexahedron order of template parameters #8362

afabri opened this issue Jul 19, 2024 · 2 comments · Fixed by #8366
Labels

Comments

@afabri
Copy link
Member

afabri commented Jul 19, 2024

Issue Details

Is there a reason why make_hexahedron() has the point type before the graph type?

@MaelRL
Copy link
Member

MaelRL commented Jul 20, 2024

It was changed recently when @janetournois added NPs (6b75fea), probably because the point parameter(s) come before the graph parameter, and usually the template parameters follow the same order.

What is the issue with the point template parameter coming first (except that it is not inconsistent throughout the make_... functions)?

@afabri
Copy link
Member Author

afabri commented Jul 21, 2024

The inconsistency makes you run in a compilation error, when you have a code where you switch from one to the other. That happened to me.

@sloriot sloriot linked a pull request Jul 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants