Add rudementary backup recovery and discord rate limiting #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonsturgeon
added
bug
Open
|
This will be added in #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes two things:
(Addresses #30)
Some notes:
cfc_err_forwarder_intervalhas been changed tocfc_err_forwarder_dedupe_duration. The setting is similar, but now has a more focused purpose, justifying a rename.ErrorForwarder will not retry failed webhooks, it will simply log the failure and move on. My thinking is that servers typically have a reliable connection (the one exception being a message that's too long), so any issue causing requests to fail would likely cause all requests to fail. To that end, I'm not sure how useful retries will actually be.