Modular api to satisfy #68 #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm. I didn't realize it was going to want to merge five pointless commits. I can resubmit with just the latest, if that's a problem. |
|
@randallsquared Thanks so much, this is awesome! I'm out of town soon but will take a closer look ASAP. Feel free to squash and force push over the branch. |
randallsquared
force-pushed
the
modularApi
branch
from
a0f727e to
316e46e
Compare
|
Fixed up commits. |
Add new method on Dispatcher: addStore to support Flux#addStore Add tests for new api functionality New: Remove misleading comments in favor of descriptive variable naming New: Edit wording of error messages for clarity
randallsquared
force-pushed
the
modularApi
branch
from
316e46e to
9904d77
Compare
|
Fixed up some strings and comments which were misleading. |
|
This looks great, @randallsquared, thanks again. #51 and #39 deal with the store API, so I don't think there's an issue here. |
|
Oh, okay. :) |
|
No problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a superset of the API mentioned in #68 with addActions/addStores supporting the current object format (and used by the Flux constructor), and addAction/addStore supporting the one-at-a-time notion.
Flux#addStore takes a name and a store, and adds the store to Flux.
Flux#addAction takes either an array of namespaces and an action function, or any number of namespaces as strings, and then an action function.
bindActions was changed to throw when encountering a collision.
I didn't check in any documentation, but I can do so if you'd prefer that to writing it yourself.