Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that the attrs option of responses_test actually work properly. #634

Closed
marcharper opened this issue Jun 17, 2016 · 3 comments
Closed
Assignees

Comments

@marcharper
Copy link
Member

marcharper commented Jun 17, 2016

Refer to the discussion at #633.

Edit: Could also look at ContriteTFT

@drvinceknight
Copy link
Member

👍

FYI, for when this is looked at ba1cce5 was failing on the expected response (the C versus the D) so it's not just the attr that aren't working in that case.

@drvinceknight
Copy link
Member

Wrong hash, I meant 27a065e

@marcharper
Copy link
Member Author

The reason for the failures are because the order of random draws is not the same in the two cases since the opponent is Random(). The test function actually calls the strategy functions (to try to set the proper internal variables) and then overwrites with the intended (not necessarily actual history). So in this case random.random() is called one additional time (in the beginning), which mucks up the random seeding.

As far I as I can tell the test function is working as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants