feat(ava-xs): handle most zoe tests #2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
approved these changes
Mar 4, 2021
kriskowal
approved these changes
Mar 4, 2021
| @@ -168,17 +168,29 @@ function createHarness(send) { | |||
| /** | |||
| * @param {*} exc | |||
| * @param {Expectation} expectation | |||
| * @returns {boolean} | |||
| * @returns {null | { expected: unknown, actual: unknown }} | |||
There was a problem hiding this comment.
@erights has advised pretending null doesn’t exist and favoring | void generally.
There was a problem hiding this comment.
pointer to said advice? I'd like to add it to /~https://github.com/Agoric/agoric-sdk/wiki/Code-Review-Checklist , along with rationale.
I find it odd that we'd prefer undefined over null, since JSON groks null.
dckc
force-pushed
the
370-xs-ava-zoe
branch
2 times, most recently
from
9852e8f to
f727b83
Compare
|
What the #$%!#@ does this mean? Why did it exit with code 1? -- /~https://github.com/Agoric/agoric-sdk/pull/2573/checks?check_run_id=2044135404 |
|
yarn test:node && yarn test:xs-unit && yarn test:xs-worker
Maybe one of the latter commands is failing without printing any output?
…On Fri, Mar 5, 2021 at 9:16 PM Dan Connolly ***@***.***> wrote:
What the #$%!#@ does this mean? Why did it exit with code 1?
312 tests passed
3 known failures
9 tests skipped
15 tests todo
error Command failed with exit code 1.
--
/~https://github.com/Agoric/agoric-sdk/pull/2573/checks?check_run_id=2044135404
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#2573 (comment)>,
or unsubscribe
</~https://github.com/notifications/unsubscribe-auth/AAAOXBR5FXZQUHA6IN3COHLTCG3DDANCNFSM4YSI3PAQ>
.
|
dckc
force-pushed
the
370-xs-ava-zoe
branch
2 times, most recently
from
0a329e6 to
f3f9aec
Compare
- support -v / --verbose - xsnap: add glob, @agoric/assert dependencies. hm... having ava-xs in the xsnap package is increasingly awkward
- add a separate test:xs-unit-debug script,
since `ava-xs --verbose --debug` isn't yet supported
- clean up some lint
- elaborate diagnostics for checkExpectation
The code running inside xsnap can't see crank boundaries, so don't bother to count planned assertions there. Count on the node parent side.
due to intermittent SEGV
Co-authored-by: Kris Kowal <kris@agoric.com>
Co-authored-by: Kris Kowal <kris@agoric.com>
|
Yay! all the robots are finally happy! I suppose I should have double-checked with the people but I lost patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #370
modulo a handful of explicitly exclude tests
fixes #2572
Each test runs its own crank.
This is a draft to see if it works reasonably well under ci.