feat: add depositToSeat, withdrawFromSeat
#1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dtribble This is looking good! I made some changes and added a companion method (withdrawfromSeat). I think we just need to write tests for this. I'll coordinate with @Chris-Hibbert since I'm writing the zcf tests and he's writing the Zoe helper tests. |
dtribble
commented
Sep 10, 2020
katelynsills
changed the title
escrowToAlldepositToSeat, withdrawFromSeat
Thesed in tests in the economy repository, and is based on prior code, but generally is not yet tested.
katelynsills
force-pushed
the
escrowAllTo
branch
from
21aea6d to
1b1dac1
Compare
katelynsills
approved these changes
Sep 10, 2020
|
Since this started life as my pull, I'll add my approval to the changes from there in this comment. Apprved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thesed in tests in the economy repository, and
is based on prior code, but generally is not yet tested.