feat(xsnap): record upstream commands as well as replies

Agoric · Aug 14, 2021 · fc9332f · fc9332f
1 parent 8c4a16b
commit fc9332f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/packages/xsnap/src/replay.js b/packages/xsnap/src/replay.js
@@ -103,6 +103,7 @@ export function recordXSnap(options, folderPath, { writeFileSync }) {
 
   /** @param { Uint8Array} msg */
   async function handleCommand(msg) {
+    nextFile('command').put(msg);
     const result = await handle(msg);
     nextFile('reply').put(result);
     return result;
@@ -213,7 +214,7 @@ export async function replayXSnap(
       const [_match, digits, kind] = parts;
       const seq = parseInt(digits, 10);
       console.log(folder, seq, kind);
-      if (running && kind !== 'reply') {
+      if (running && !['command', 'reply'].includes(kind)) {
         // eslint-disable-next-line no-await-in-loop
         await running;
         running = undefined;
@@ -230,6 +231,9 @@ export async function replayXSnap(
         case 'issueCommand':
           running = it.issueCommand(file.getData());
           break;
+        case 'command':
+          // ignore; we already know how to reply
+          break;
         case 'reply':
           replies.put(file.getData());
           break;

diff --git a/packages/xsnap/test/test-replay.js b/packages/xsnap/test/test-replay.js
@@ -21,7 +21,8 @@ const transcript1 = [
     '/xsnap-tests/00001-evaluate.dat',
     'issueCommand(ArrayBuffer.fromString("Hello, World!"));',
   ],
-  ['/xsnap-tests/00002-reply.dat', ''],
+  ['/xsnap-tests/00002-command.dat', '{"compute":54'],
+  ['/xsnap-tests/00003-reply.dat', ''],
 ];
 
 test('record: evaluate and issueCommand', async t => {
@@ -72,6 +73,7 @@ test('replay', async t => {
 
   t.deepEqual(done, [
     ['/xs-test/', 1, 'evaluate'],
-    ['/xs-test/', 2, 'reply'],
+    ['/xs-test/', 2, 'command'],
+    ['/xs-test/', 3, 'reply'],
   ]);
 });