fix: restoring most state, just need to isolate the plugin captp

packages/SwingSet/src/devices/plugin-src.js

@@ -6,7 +6,7 @@ export function buildRootDeviceNode(tools) {
   const { SO, getDeviceState, setDeviceState, endowments } = tools;
   const restart = getDeviceState();
 
-  let registeredReceiver;
+  let registeredReceiver = restart && restart.registeredReceiver;
 
   const connectedMods = [];
   const senders = [];
@@ -15,7 +15,8 @@ export function buildRootDeviceNode(tools) {
   function saveState() {
     setDeviceState(
       harden({
-        connectedMods,
+        registeredReceiver,
+        connectedMods: [...connectedMods],
         connectedState: [...connectedState],
       }),
     );
@@ -34,14 +35,11 @@ export function buildRootDeviceNode(tools) {
       connectedMods.push(mod);
       const receiver = obj => {
         console.info('receiver', index, obj);
-        switch (obj.type) {
-          case 'PLUGIN_SAVE_STATE':
-            connectedState[index] = obj.data;
-            saveState();
-            break;
-          default:
-            SO(registeredReceiver).receive(index, obj);
-        }
+
+        // We need to run the kernel after the send-only.
+        endowments.queueThunkForKernel(() =>
+          SO(registeredReceiver).receive(index, obj),
+        );
       };
       // Create a bootstrap reference from the module.
       const bootstrap = modNS.bootPlugin(
@@ -88,7 +86,11 @@ export function buildRootDeviceNode(tools) {
     connect,
     send,
     registerReceiver(receiver) {
+      if (registeredReceiver) {
+        throw Error(`registerd receiver already set`);
+      }
       registeredReceiver = receiver;
+      saveState();
     },
   });
 }

packages/SwingSet/src/devices/plugin.js

@@ -1,10 +1,10 @@
-export function buildPlugin(pluginRequire) {
+export function buildPlugin(pluginRequire, queueThunkForKernel) {
   const srcPath = require.resolve('./plugin-src');
 
   // srcPath and endowments are provided to buildRootDeviceNode() for use
   // during configuration.
   return {
     srcPath,
-    endowments: { require: pluginRequire },
+    endowments: { require: pluginRequire, queueThunkForKernel },
   };
 }

packages/SwingSet/src/kernel/liveSlots.js

@@ -380,8 +380,8 @@ function build(
         // It has arguments, must be a method application.
         res = HandledPromise.applyMethod(t, method, args);
       } else {
-        // TODO: untested, but in principle sound.
         // Just a getter.
+        // TODO: untested, but in principle sound.
         res = HandledPromise.get(t, method);
       }
       res.then(notifySuccess, notifyFailure);

packages/cosmic-swingset/lib/ag-solo/hello.js

@@ -8,7 +8,7 @@ export const bootPlugin = ({ getState, setState }) => {
     async hello(name) {
       state = { count: state.count + 1 };
       setState(state);
-      await fs.writeFile(dataFile, `Said hello ${state.count} times`);
+      await fs.writeFile(dataFile, `Said hello ${state.count} times\n`);
       return `Hello, ${name}`;
     },
   });

packages/cosmic-swingset/lib/ag-solo/start.js

@@ -88,7 +88,14 @@ async function buildSwingset(
   const mb = buildMailbox(mbs);
   const cm = buildCommand(broadcast);
   const timer = buildTimer();
-  const plugin = buildPlugin(require);
+  const withInputQueue = makeWithQueue();
+  const queueThunkForKernel = withInputQueue(async thunk => {
+    thunk();
+    // eslint-disable-next-line no-use-before-define
+    await processKernel();
+  });
+
+  const plugin = buildPlugin(require, queueThunkForKernel);
 
   let config = loadSwingsetConfigFile(`${vatsDir}/solo-config.json`);
   if (config === null) {
@@ -127,8 +134,6 @@ async function buildSwingset(
     }
   }
 
-  const withInputQueue = makeWithQueue();
-
   // Use the input queue to make sure it doesn't overlap with
   // other inbound messages.
   const queuedDeliverInboundToMbx = withInputQueue(

packages/eventual-send/src/index.js

@@ -363,6 +363,12 @@ export function makeHandledPromise() {
         }
         return t(...args);
       }
+      if (!t) {
+        const ftype = typeof t;
+        throw new TypeError(
+          `target cannot contain [${method}], typeof is ${ftype}`,
+        );
+      }
       if (!(method in t)) {
         const names = Object.getOwnPropertyNames(t).sort();
         throw new TypeError(`target[${method}] does not exist, has ${names}`);