Skip to content

Commit

Permalink
fix: use --expose-gc for top-level 'yarn test'
Browse files Browse the repository at this point in the history
I added this to SwingSet/package.json in commit
d4bc617 (PR #3136). However I overlooked the
fact that #3100 had already landed, which changed the top-level `yarn test`
from one that just did a (sequential) `yarn workspaces test`, testing one
package at a time with whatever the local `package.json` said to do, to one
that does a (parallel) `ava` invocation, which does all packages at the same
time but ignores the local `package.json` settings.

We need to include `--expose-gc` in the `nodeArguments` in the top-level
package.json to make sure the parallel form give the correct arguments when
SwingSet's turn comes around (as well as other packages which benefit from
enabling GC but don't have tests which directly assert that it can be done).
  • Loading branch information
warner committed May 25, 2021
1 parent 74869fe commit 352922a
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@
"files": [
"packages/*/test/**/test-*.js"
],
"nodeArguments": [
"--expose-gc"
],
"require": [
"esm"
],
Expand Down

0 comments on commit 352922a

Please sign in to comment.