Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream doh validate is wrong #411

Closed
sanyo0714 opened this issue Aug 14, 2024 · 1 comment
Closed

upstream doh validate is wrong #411

sanyo0714 opened this issue Aug 14, 2024 · 1 comment
Assignees

Comments

@sanyo0714
Copy link

2024/08/13 20:10:52 [fatal] Cannot create an upstream: invalid address xxx_xxx.xxxx.com: bad hostname "xxx_xxx.xxxx.com": bad hostname label "xxx_xxx": bad hostname label rune '_'

domain name also need follow https://datatracker.ietf.org/doc/html/rfc2181#autoid-30

@EugeneOne1 EugeneOne1 self-assigned this Aug 15, 2024
@EugeneOne1
Copy link
Member

Hello, @sanyo0714. This change might actually make sense since we already allow so-called "domain names" (as opposed to "hostnames") to be used within upstream domain specifications. Perhaps using the same validation rules for upstream names and their domain specifications would make the API more consistent and predictable.

@ameshkov, what do you think? Just in case, see AdguardTeam/golibs#9 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants