-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to ACS v23.x #41
Conversation
Oh wow... that is an amazing PR for one of the most sore points of my TODO-list. Thank you for that. |
I am still testing it out. But I thought I would throw it up here. I plan to get it working today, but there may be another commit to the branch. I am going to open another request on the 23.1 project that is still referencing surf v6.11 instead of v9. Backward compatibility is a pain with jakarta. Are you planning to maintain multiple branches or do it with multiple source paths and profiles? |
After re-reading your post, I guess you will go with the multiple paths/profiles method. Do you want me to try to do that split? |
c77de5f
to
d5ef5a7
Compare
an upgrade in v23 to httpclient and deprecation is making |
The latest fix has everything at least working in the |
Ok, the Share module is now working, with some undesirable changes. The forced route feature is now done through the Feel free to chop it all up. I will be using my branch for now. |
Hi @bmlong137 it took a long time but I have just pushed a squashed and somewhat refactored variant of your branch in this project. Due to stability and licensing issues running Docker Desktop for my work, I have for a while now been running my Docker engine on Ubuntu via a Windows Subsystem for Linux. This exposed the need to refactor all of my projects to support working in a Docker context using a remote Docker engine. There now is a sub-module |
I merged my pull request. I also fixed the issue with the source attachment there and added a GitHub action to check the build. |
This includes upgrades using the acosix parent projects. The major change here is the switch to Jakarta and JDK17.
The only thing "not working" as before is that the shade plugin source generation had to be disabled. It creates a
sources
classifier that conflicts with the main artifactsources
classifier. This is a new error inmaven-source-plugin
v3.3.0+ and I needed to upgrade that due to a class version conflict issue.