Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ACS v23.x #41

Closed
wants to merge 8 commits into from
Closed

Conversation

bmlong137
Copy link

This includes upgrades using the acosix parent projects. The major change here is the switch to Jakarta and JDK17.

The only thing "not working" as before is that the shade plugin source generation had to be disabled. It creates a sources classifier that conflicts with the main artifact sources classifier. This is a new error in maven-source-plugin v3.3.0+ and I needed to upgrade that due to a class version conflict issue.

@AFaust
Copy link
Member

AFaust commented Aug 23, 2024

Oh wow... that is an amazing PR for one of the most sore points of my TODO-list. Thank you for that.
I have always envisioned my modules to be compatible across multiple ACS versions, and the whole Jakarta switch made this a real challenge. Since you updated the references to the Acosix parent / utility module, you might have seen what I did to have the utility module be compatible with both pre-23.x and 23.x onwards. Something along those lines was what I was hoping to do for the Keycloak module too (when I would find the time).
I am considering to merge this PR (maybe with small code style changes in one or two places) to finally have the 1.2.0-rc1 as a preliminary "ACS 23-compatible" version, but still planning to work on a follow-up for backwards compatiblity at least for 7.x versions.

@bmlong137
Copy link
Author

bmlong137 commented Aug 23, 2024

I am still testing it out. But I thought I would throw it up here. I plan to get it working today, but there may be another commit to the branch.

I am going to open another request on the 23.1 project that is still referencing surf v6.11 instead of v9.

Backward compatibility is a pain with jakarta. Are you planning to maintain multiple branches or do it with multiple source paths and profiles?

@bmlong137
Copy link
Author

After re-reading your post, I guess you will go with the multiple paths/profiles method. Do you want me to try to do that split?

@bmlong137
Copy link
Author

an upgrade in v23 to httpclient and deprecation is making forced-route-url very difficult. Naturally, it is a feature I really care about.

@bmlong137
Copy link
Author

The latest fix has everything at least working in the repo. The Share forced-route-url is still an issue though. I am weighing how important Share is in v23.x, but I will continue to see if there is a reasonable way to get that to work.

@bmlong137
Copy link
Author

Ok, the Share module is now working, with some undesirable changes. The forced route feature is now done through the HttpRoutePlanner, which could only be set by creating a whole new HttpClientBuilder. A bit more to maintain.

Feel free to chop it all up. I will be using my branch for now.

@AFaust
Copy link
Member

AFaust commented Feb 14, 2025

Hi @bmlong137

it took a long time but I have just pushed a squashed and somewhat refactored variant of your branch in this project. Due to stability and licensing issues running Docker Desktop for my work, I have for a while now been running my Docker engine on Ubuntu via a Windows Subsystem for Linux. This exposed the need to refactor all of my projects to support working in a Docker context using a remote Docker engine. There now is a sub-module docker-test that runs a Docker Compose-based integrated Keycloak + ACS + Share setup for manual/interactive tests. In the future, I hope to also add integration tests that act as a 3rd-party app or user agent.

This was referenced Feb 20, 2025
@AFaust
Copy link
Member

AFaust commented Feb 21, 2025

I merged my pull request. I also fixed the issue with the source attachment there and added a GitHub action to check the build.

@AFaust AFaust closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants