Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Session related events propagation #387

Open
jibon57 opened this issue Jul 26, 2024 · 2 comments
Open

feat: Session related events propagation #387

jibon57 opened this issue Jul 26, 2024 · 2 comments

Comments

@jibon57
Copy link
Contributor

jibon57 commented Jul 26, 2024

Description

At present from server end session related events are not propagating to client /~https://github.com/8xFF/atm0s-media-server/blob/b63e5cfba049b6421cdd576da5e0fb802c012d49/packages/protocol/proto/sdk/session.proto#L199C13-L199C20
Those are also important events from client side. It will be nice to have those.

discussion: https://discord.com/channels/1173844241542287482/1173844241542287485/1266298331609567284

Steps to Reproduce

  1. Step 1
  2. Step 2
  3. Step 3

Expected Behavior

Please describe what you expected to happen.

Actual Behavior

Please describe what actually happened.

Screenshots

If applicable, add screenshots to help explain the issue.

Environment

  • Operating System:
  • Browser (if applicable):
  • Version (if applicable):

Additional Information

Add any other relevant information about the issue here.

@jibon57
Copy link
Contributor Author

jibon57 commented Jul 26, 2024

in this event:

having following info will be helpful:

string room = 1;
string peer = 2;
optional string metadata = 3;
optional string extra_data = 4;

string reason =  1;
bool graceful = 2;

based on graceful we can implement reconnection policy from client end. If graceful then do not need to reconnect.

I think you can also added MetadataUpdated, ExtraDataUpdated so that we can use those later.

@jibon57
Copy link
Contributor Author

jibon57 commented Jul 26, 2024

sender: /~https://github.com/8xFF/atm0s-media-server/blob/b63e5cfba049b6421cdd576da5e0fb802c012d49/packages/protocol/proto/sdk/session.proto#L148C1-L158C10
receiver: /~https://github.com/8xFF/atm0s-media-server/blob/b63e5cfba049b6421cdd576da5e0fb802c012d49/packages/protocol/proto/sdk/session.proto#L167C1-L178C10

should have more information like track name, peer etc so that we can expose those in client side & application can use those for various purposes. For example: I have shared/detached media but do not know if that was successful or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant