Reduce stack consumption #95
Conversation
ghost
force-pushed
the
stack-safety
branch
6 times, most recently
from
3e321a0 to
92d9c7e
Compare
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 77.1% 77.59% +0.49%
==========================================
Files 10 10
Lines 249 250 +1
Branches 2 2
==========================================
+ Hits 192 194 +2
+ Misses 57 56 -1
Continue to review full report at Codecov.
|
|
This looks great, looks like codecov says it decreased in 3% though and bumps it below 80% which we may want to address if it's something we can do as part of this PR. This improvements deserves a new release 👏 |
| .map((x) => (0 until 2).toList.traverse(fetchBatchedDataSeq)) | ||
| .foldLeft( | ||
| Fetch.pure(List.empty[Int]) | ||
| )((acc, f) => acc.flatMap((x) => f)) |
There was a problem hiding this comment.
This foldLeft with pure and flatMap could also be written using the monadic fold (Foldable#foldM).
Something like (might need some type annotations):
import cats.instances.list._
import cats.syntax.foldable._
.foldM(List.empty[Int])((_, f) => f)
// or using foldMapM (this does combine all the lists though)
.foldMapM(identity)| } | ||
| } | ||
|
|
||
| class FetchTests extends AsyncFreeSpec with Matchers { |
There was a problem hiding this comment.
Have we dropped these ?
Seems we are removing around 550 lines in this PR, which is more or less the same as these tests ?
|
@peterneyens i added the lost tests back and changed the |
|
|
Tried some extreme cases and found a couple of parts in the code where we could reduce stack consumption. Unfortunately the tests are failing due to a timeout in Travis CI, looking into it right now.