Don't depend on the cache contents for simplifying joined trees #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val ds: DataSource[Any, _] = fm.ds.asInstanceOf[DataSource[Any, _]] | ||
|
|
||
| ids | ||
| .map(id => { |
There was a problem hiding this comment.
Nothing wrong with this but the I'd and block it's verbose. May be simplified like the next chained call
There was a problem hiding this comment.
I've refactored this in another branch, will submit a PR soon.
|
LGTM! |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@raulraja please take a look.
This opens the door to using custom caches that don't remember all the elements, for instance caches with an LRU policy. Also if we where using a custom remote cache (like memcached) that is unreachable and thus we cannot read from it (return
NonefromDataSourceCache#get), fetches will continue without problem querying the data source.Previously wasn't possible to use a custom cache that forgot elements so I'd like to cut a release with these changes.
Closes #47