Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings across project #422

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Conversation

sloshy
Copy link
Contributor

@sloshy sloshy commented Jan 14, 2021

Some code used features of Scala or http4s that either were deprecated, or confused the compiler while being technically usable. This tweaks the code that's there just enough to get it all working without warnings.

  • No more procedure syntax
  • Pattern matching casts are now done explicitly
  • http4s client .fetch syntax is deprecated, replaced w/ .run.use
  • Replace ? with * for kind projector usage

@github-actions github-actions bot added the bug Something isn't working label Jan 14, 2021
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #422 (b214738) into master (db771e0) will increase coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
+ Coverage   67.55%   67.88%   +0.32%     
==========================================
  Files           8        8              
  Lines         299      302       +3     
  Branches        5        6       +1     
==========================================
+ Hits          202      205       +3     
  Misses         97       97              
Impacted Files Coverage Δ
fetch-debug/src/main/scala/document.scala 0.00% <ø> (ø)
fetch/src/main/scala/fetch.scala 89.70% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db771e0...b214738. Read the comment docs.

@sloshy sloshy requested a review from rafaparadela January 14, 2021 20:46
Copy link

@rafaparadela rafaparadela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the explicit casting, but as long as removing compilation warnings is the motivation, I'm ok with that :-)
Thanks for the efforts.

@sloshy sloshy merged commit 66b1cf6 into master Jan 15, 2021
@sloshy sloshy deleted the fix/compiler-warnings-2020-01-13 branch January 15, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants