-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes dup doc files #117
Conversation
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=======================================
Coverage 77.59% 77.59%
=======================================
Files 10 10
Lines 250 250
Branches 2 2
=======================================
Hits 194 194
Misses 56 56 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks!
Minor comment added
project/ProjectPlugin.scala
Outdated
@@ -52,8 +52,8 @@ object ProjectPlugin extends AutoPlugin { | |||
aggregate in doc := true) | |||
|
|||
lazy val readmeSettings: Seq[Def.Setting[_]] = tutSettings ++ commonTutSettings ++ Seq( | |||
tutSourceDirectory := baseDirectory.value, | |||
tutTargetDirectory := baseDirectory.value.getParentFile, | |||
tutSourceDirectory := baseDirectory.value.getParentFile, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could use here (baseDirectory in LocalRootProject).value
instead
project/ProjectPlugin.scala
Outdated
tutSourceDirectory := baseDirectory.value, | ||
tutTargetDirectory := baseDirectory.value.getParentFile, | ||
tutSourceDirectory := baseDirectory.value.getParentFile, | ||
tutTargetDirectory := baseDirectory.value.getParentFile / "target", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
@@ -82,6 +82,7 @@ object ProjectPlugin extends AutoPlugin { | |||
ScalaJSBadge.apply(_), | |||
GitHubIssuesBadge.apply(_) | |||
), | |||
orgSupportedScalaJSVersion := Some("0.6.15"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR removes some unneeded files and it also removes the
README.md
file inside the tut directory. Hence, tut will compile the file in the root folder instead.Please, @fedefernandez could you review? Thanks!