Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links that break into a new line don't get recognized completely #622

Open
preetmishra opened this issue Apr 24, 2020 · 6 comments
Open

Comments

@preetmishra
Copy link
Member

Whenever any link gets broken into a new line, hovering the mouse over them only recognizes the first line, the one with 'https://', as a link.

This behaviour makes these links invalid to use (e.g. opening the link in any web browser).

Screenshots:

image

image

@preetmishra
Copy link
Member Author

@zulipbot add "further discussion required"

@zulipbot zulipbot added the further discussion required Discuss this on #zulip-terminal on chat.zulip.org label Apr 24, 2020
@neiljp
Copy link
Collaborator

neiljp commented Jul 22, 2020

@preetmishra This is improved dramatically now that #703 is merged, but with a FAQ entry and the popup I think we can definitely close this.

@neiljp neiljp removed the further discussion required Discuss this on #zulip-terminal on chat.zulip.org label Jul 22, 2020
@preetmishra
Copy link
Member Author

@neiljp While this is improved, it is still unusable when the links spread across, say, two lines. We may want to wait until we handle all the links via #708 and its follow-ups to close this (which I believe is what you meant).

@neiljp
Copy link
Collaborator

neiljp commented Jul 24, 2020

@preetmishra Do you think this is fixed now?

@preetmishra
Copy link
Member Author

@neiljp This is mostly fixed. We have drastically decreased the number of cases where the links could split over two lines. However, we still don't have a way to make links that are split over two lines usable.

I believe we could close this once we support handling internal/external links or atleast copying links to the clipboard.

@zulipbot
Copy link
Member

zulipbot commented Sep 8, 2020

Hello @preetmishra, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants