Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access to Yomitan features via cross-extension communication #1797

Open
killergerbah opened this issue Feb 2, 2025 · 2 comments
Open
Labels
area/api The issue or PR is related to API between Yomitan and other scripts or applications kind/enhancement The issue or PR is a new feature or request

Comments

@killergerbah
Copy link

Hello, I am the maintainer of asbplayer, a sentence-mining browser extension for streaming video.

I do not have experience with this API myself but based on this documentation, it looks like it would relatively easy to expose an entry-point into Yomitan code that's callable from an extension like asbplayer. In particular, I would love if it were possible to extend asbplayer with some of Yomitan's flagship features, such as lemmatization and dictionary word lookups. Most users use asbplayer in combination with Yomitan anyway, so ideally this would be one extra step to make sentence-mining on asbplayer nearly on par with similar software like Migaku. Currently, asbplayer implements a workaround via a WebSocket server to achieve related behavior.

@killergerbah killergerbah added the kind/enhancement The issue or PR is a new feature or request label Feb 2, 2025
@Kuuuube Kuuuube added the area/api The issue or PR is related to API between Yomitan and other scripts or applications label Feb 8, 2025
@djahandarie
Copy link
Collaborator

I think it's totally fine to implement such an interface, but I think it will take a contribution from someone outside of the maintainer list for it to happen, basically because it's a big chunk of work and therefore requires someone motivated to work on it. We are happy to review.

@killergerbah
Copy link
Author

Thanks for the response. I may take a stab at this when I am able to find the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api The issue or PR is related to API between Yomitan and other scripts or applications kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

No branches or pull requests

3 participants