-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mutiple Field Checks for Duplicate Card Detection #1793
Comments
Is this an issue with yomitan or anki-connect? we invoke canAddNotes and change whether or not we allow duplicates but isn't it anki-connect that chooses which fields to compare? |
I suppose it would be latter, but you likely know way more than me. I thought that since Yomitan had a configurable Anki Card format that it was also responsible for duplicate detection. |
What do you think @Kuuuube ? |
Afaik you are correct in this being an ankiconnect issue. I'm not sure if it's possible to sanely work around this (we dont want to be sending a ton of requests). If it got implemented in ankiconnect then it could be considered for yomitan. Maybe make a poc with yomitan and ankiconnect before submitting a patch to ankiconnect if you want to actually work on it so it can be reviewed on the yomitan side first. |
This does seem like an AnkiConnect issue. If you only care about checking for duplicates on one particular field, then the easiest solution for now is to simply reorder that field to be the 1st one in your note type (as it's what AnkiConnect uses for duplicate detection, rather than the sort field) |
Alrighty, thanks for looking into it. |
Not related to Yomitan, but is there a good way to raise this issue with AnkiConnect? I'd like to do so. I see it's been migrated away from GitHub and there's no obvious contact button on either their website or the new git host website |
Currently, to check duplicates, Yomitan uses specifically the first field of any card (regardless of Anki's sort field).
Rather than do this, perhaps have it so that you can specify the field(s) that are checked, and if all are matching a given card, than the card is detected as a duplicate. This would also be good for setting multiple fields for recognizing new cards. This way words with the same kanji form can be recognized as not duplicates, as they have a different word reading, and since Yomitan is checking two fields now instead of one, it won't be registered as a false positive duplicate.
The text was updated successfully, but these errors were encountered: