From a4afa34787eb0adbc13f1af57a30ad0d5f85460c Mon Sep 17 00:00:00 2001 From: Fabiana Clemente Date: Tue, 9 Jul 2024 11:01:08 -0700 Subject: [PATCH] fix: rmv analytcis from the tests --- .github/workflows/tests.yml | 7 ++++++- src/ydata_profiling/utils/logger.py | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 032022537..44483e2e6 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -1,6 +1,8 @@ name: Multi-software test - +env: + YDATA_PROFILING_NO_ANALYTICS: False + on: pull_request: push: @@ -20,6 +22,7 @@ jobs: pandas: ["pandas>1.1"] numpy: ["numpy"] matplotlib: ["matplotlib<3.9"] + analytics: False include: - os: ubuntu-22.04 python-version: 3.7.16 @@ -130,6 +133,7 @@ jobs: pip install --upgrade pip setuptools wheel pip install -r requirements.txt "${{ matrix.pandas }}" "${{ matrix.numpy }}" pip install -r requirements-test.txt + echo $YDATA_PROFILING_NO_ANALYTICS - run: make install - run: make test_cov @@ -170,6 +174,7 @@ jobs: HADOOP_VERSION: ${{ matrix.hadoop }} SPARK_DIRECTORY: ${{ github.workspace }}/../ SPARK_HOME: ${{ github.workspace }}/../spark/ + YDATA_PROFILING_NO_ANALYTICS: ${{ matrix.analytics }} steps: - uses: actions/checkout@v4 - name: Setup python diff --git a/src/ydata_profiling/utils/logger.py b/src/ydata_profiling/utils/logger.py index bbe2f5a76..18a51b1d3 100644 --- a/src/ydata_profiling/utils/logger.py +++ b/src/ydata_profiling/utils/logger.py @@ -17,7 +17,7 @@ def info_def_report(self, dataframe, timeseries: bool) -> None: # noqa: ANN001 if isinstance(dataframe, pd.DataFrame): dataframe = "pandas" report_type = "regular" - elif isinstance(dataframe, None): + elif dataframe is None: dataframe = "pandas" report_type = "compare" else: