From 7c7973547dcae0eb67c317f9675aac6b8893d5bb Mon Sep 17 00:00:00 2001 From: HyungUk Ryu Date: Tue, 6 Aug 2024 21:48:59 +0900 Subject: [PATCH] =?UTF-8?q?fix(ScheduleCreateRequest):=20=EC=8A=A4?= =?UTF-8?q?=EC=BC=80=EC=A4=84=20=EC=83=9D=EC=84=B1=20=EC=8B=9C=20=EC=82=AC?= =?UTF-8?q?=EC=9A=A9=EC=9E=90=EC=9D=98=20=EC=9D=B4=EB=A6=84=20=EC=A0=95?= =?UTF-8?q?=EB=B3=B4=EB=A5=BC=20=EC=A0=84=EB=8B=AC=EB=B0=9B=EC=A7=80=20?= =?UTF-8?q?=EC=95=8A=EB=8F=84=EB=A1=9D=20=EB=B3=80=EA=B2=BD?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../schedule/dto/ScheduleCreateRequest.java | 3 +-- .../schedule/ScheduleControllerTest.java | 2 +- .../service/schedule/ScheduleServiceTest.java | 19 +++---------------- 3 files changed, 5 insertions(+), 19 deletions(-) diff --git a/backend/src/main/java/kr/momo/service/schedule/dto/ScheduleCreateRequest.java b/backend/src/main/java/kr/momo/service/schedule/dto/ScheduleCreateRequest.java index 3dd0b26f3..44d9a9d88 100644 --- a/backend/src/main/java/kr/momo/service/schedule/dto/ScheduleCreateRequest.java +++ b/backend/src/main/java/kr/momo/service/schedule/dto/ScheduleCreateRequest.java @@ -1,8 +1,7 @@ package kr.momo.service.schedule.dto; -import jakarta.validation.constraints.NotBlank; import jakarta.validation.constraints.NotNull; import java.util.List; -public record ScheduleCreateRequest(@NotBlank String attendeeName, @NotNull List dateTimes) { +public record ScheduleCreateRequest(@NotNull List dateTimes) { } diff --git a/backend/src/test/java/kr/momo/controller/schedule/ScheduleControllerTest.java b/backend/src/test/java/kr/momo/controller/schedule/ScheduleControllerTest.java index 9ce091962..2d201a3ae 100644 --- a/backend/src/test/java/kr/momo/controller/schedule/ScheduleControllerTest.java +++ b/backend/src/test/java/kr/momo/controller/schedule/ScheduleControllerTest.java @@ -82,7 +82,7 @@ void create() { new DateTimesCreateRequest(tomorrow.getDate(), times) ); - ScheduleCreateRequest scheduleCreateRequest = new ScheduleCreateRequest(attendee.name(), dateTimes); + ScheduleCreateRequest scheduleCreateRequest = new ScheduleCreateRequest(dateTimes); RestAssured.given().log().all() .cookie("ACCESS_TOKEN", token) diff --git a/backend/src/test/java/kr/momo/service/schedule/ScheduleServiceTest.java b/backend/src/test/java/kr/momo/service/schedule/ScheduleServiceTest.java index 2ac4cec25..eb234b7db 100644 --- a/backend/src/test/java/kr/momo/service/schedule/ScheduleServiceTest.java +++ b/backend/src/test/java/kr/momo/service/schedule/ScheduleServiceTest.java @@ -79,7 +79,7 @@ void setUp() { @DisplayName("스케줄 생성 시 사용자의 기존 스케줄들을 모두 삭제하고 새로운 스케줄을 저장한다.") @Test void createSchedulesReplacesOldSchedules() { - ScheduleCreateRequest request = new ScheduleCreateRequest(attendee.name(), dateTimes); + ScheduleCreateRequest request = new ScheduleCreateRequest(dateTimes); scheduleRepository.saveAll(List.of( new Schedule(attendee, today, Timeslot.TIME_0130), new Schedule(attendee, tomorrow, Timeslot.TIME_0130) @@ -97,33 +97,20 @@ void throwsExceptionWhenInvalidUUID() { Meeting other = MeetingFixture.DINNER.create(); String invalidUUID = other.getUuid(); long attendeeId = attendee.getId(); - ScheduleCreateRequest request = new ScheduleCreateRequest(attendee.name(), dateTimes); + ScheduleCreateRequest request = new ScheduleCreateRequest(dateTimes); assertThatThrownBy(() -> scheduleService.create(invalidUUID, attendeeId, request)) .isInstanceOf(MomoException.class) .hasMessage(MeetingErrorCode.INVALID_UUID.message()); } - @DisplayName("약속에 참가자 정보가 존재하지 않으면 예외를 발생시킨다.") - @Test - void throwsExceptionWhenInvalidAttendee() { - long invalidAttendeeId = 2L; - String invalidAttendeeName = "invalidAttendeeName"; - String uuid = meeting.getUuid(); - ScheduleCreateRequest request = new ScheduleCreateRequest(invalidAttendeeName, dateTimes); - - assertThatThrownBy(() -> scheduleService.create(uuid, invalidAttendeeId, request)) - .isInstanceOf(MomoException.class) - .hasMessage(AttendeeErrorCode.INVALID_ATTENDEE.message()); - } - @DisplayName("스케줄 생성시 약속이 잠겨있다면 예외를 발생시킨다.") @Test void throwsExceptionWhenMeetingLocked() { Meeting game = MeetingFixture.GAME.create(); game.lock(); Meeting lockedMeeting = meetingRepository.save(game); - ScheduleCreateRequest request = new ScheduleCreateRequest(attendee.name(), dateTimes); + ScheduleCreateRequest request = new ScheduleCreateRequest(dateTimes); String givenUUID = lockedMeeting.getUuid(); Long givenAttendeeId = attendee.getId();