Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone step is skipped for cron job #1716

Closed
5 tasks done
dessalines opened this issue Apr 24, 2023 · 6 comments
Closed
5 tasks done

Clone step is skipped for cron job #1716

dessalines opened this issue Apr 24, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@dessalines
Copy link
Contributor

Component

agent

Describe the bug

When running a when: cron job, the woodpecker clone plugin step is skipped:

woodpecker.yml:

clone: 
  git: 
  ...

Working clone / git step:

Examples of broken for cron jobs:

System Info

{"source":"/~https://github.com/woodpecker-ci/woodpecker","version":"next-3a475ce2"}

Additional context

No response

Validations

  • Read the Contributing Guidelines.
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.
@6543
Copy link
Member

6543 commented Apr 29, 2023

my asumption:
as by default the clone step gets added if not exist when all when filters are falidated it still gets added for cron

but asap you have a custom clone step you get the default cron filter too and so it's filtered out

so we either have to add a specific case that take this into account or do drop default filter and let cron jobs run wild by default 😓 ...

@6543
Copy link
Member

6543 commented Apr 29, 2023

@dessalines for you the workaround would be to add a when filter to the clone step and add events: cron, pull, push,tag ...

@6543
Copy link
Member

6543 commented Apr 30, 2023

-> #1451

@dessalines
Copy link
Contributor Author

Thanks... should I close this in favor of the other issue?

@6543
Copy link
Member

6543 commented Apr 30, 2023

no let it open its still an issue

Nutomic added a commit to LemmyNet/lemmy that referenced this issue Jun 15, 2023
Maybe this will fix problems with wrong code being built.

woodpecker-ci/woodpecker#1716
@qwerty287
Copy link
Contributor

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants