-
-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Spawn a process instead of relying on main thread #1084
Comments
Can you elaborate this, quite unclear with the flow! |
@anikethsaha no, we don't create a new process when running the CLI. We do that only when running external commands. The idea would be to run a new process when running our main code. So if the new user runs: webpack -c ./webpack.config.js --node-args "memory_size=1024" Internally, we would re run something like this using a new process: node --memory_size=1024 ./cli.js -c ./webpack.config.js I think we could use |
Reopening. This work is halfway done. We have now to spawn a process for the cli itself. |
@ematipico can you add more details please? |
@smelukov yes, when we pass |
I'll deal with it ;) |
Is your feature request related to a problem? Please describe.
On
next
branch and in generalwebpack
, we're using the thread singly to run webpack. This turns out to be a problem both earlier when trying to integrate node flag support #289 and in node v12 when trying to implement a wrapper to support the new modules declarations ( nodejs/modules#389).Describe the solution you'd like
Implement a child-process communication when spawning webpack in order to re-run CLI when supporting nodev12 with the experimental flag (we can check node version number for a user and append flag, then re-run a fresh process)
Describe alternatives you've considered
N/A
Additional context
This would probably take some time, but is really important to the new CLI.
The text was updated successfully, but these errors were encountered: