Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support input parameters using with map key. #15

Open
webispy opened this issue Jul 20, 2022 · 2 comments
Open

Support input parameters using with map key. #15

webispy opened this issue Jul 20, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@webispy
Copy link
Owner

webispy commented Jul 20, 2022

Github action support a map of input parameters via the with keyword. Therefore, the checkpatch-action also needs to be modified to support it.

@webispy webispy added the enhancement New feature or request label Jul 20, 2022
@webispy webispy added this to the v8 milestone Jul 20, 2022
@webispy webispy self-assigned this Jul 20, 2022
@webispy webispy modified the milestones: v8, v9 Jul 27, 2022
@johankor
Copy link

Would this be needed to use the with solution you described in #27 ?

@webispy
Copy link
Owner Author

webispy commented May 15, 2023

The current checkpatch-action is receiving input values through environment variables, but according to the GitHub Actions guide, input should be received using the with keyword. While it is possible to also support #27 issues using the existing approach, it would be better to support them using the with keyword.

Currently, I haven't started the work and have put it on hold since there hasn't been a request for it. However, if you want the support, I will consider changing the priority of the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants