From c5382076cda79f55667222ec65cc83ab01d06fe3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jes=C3=BAs=20Benito=20Calzada?= Date: Tue, 8 Nov 2022 13:18:08 +0100 Subject: [PATCH 1/3] Trigger GHA release workflow on tags following `test-*` pattern MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Jesús Benito Calzada --- .github/workflows/kubeapps-release.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/kubeapps-release.yml b/.github/workflows/kubeapps-release.yml index de953e9cb4f..73d73aef35a 100644 --- a/.github/workflows/kubeapps-release.yml +++ b/.github/workflows/kubeapps-release.yml @@ -8,6 +8,7 @@ on: push: tags: - 'v[0-9]+.[0-9]+.[0-9]+' + - 'test-.*' concurrency: group: ${{ github.head_ref || github.ref_name }}_release From d11edd43edf779c905f9288da97cb68562f657aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jes=C3=BAs=20Benito=20Calzada?= Date: Thu, 10 Nov 2022 11:56:45 +0100 Subject: [PATCH 2/3] Force DEV_MODE when triggered by a "test release" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Jesús Benito Calzada --- .github/workflows/kubeapps-general.yaml | 11 +++++++++-- .github/workflows/kubeapps-release.yml | 1 + 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/.github/workflows/kubeapps-general.yaml b/.github/workflows/kubeapps-general.yaml index e6911260f5c..55accc3bdef 100644 --- a/.github/workflows/kubeapps-general.yaml +++ b/.github/workflows/kubeapps-general.yaml @@ -138,8 +138,15 @@ jobs: else echo "running_on_tag=false" >> $GITHUB_OUTPUT fi - - echo "dev_mode=${DEV_MODE}" >> $GITHUB_OUTPUT + + # TODO(bjesus) Once we've properly tested the release job, we can/should remove this hack, just leave the content from the else branch + if [[ ${GITHUB_REF_TYPE} == "tag" && ${GITHUB_REF_NAME} == 'test-'* ]]; then + echo "DEV_MODE=true" >> $GITHUB_ENV + echo "dev_mode=true" >> $GITHUB_OUTPUT + else + echo "dev_mode=${DEV_MODE}" >> $GITHUB_OUTPUT + fi + echo "golang_version=${GOLANG_VERSION}" >> $GITHUB_OUTPUT echo "ssh_key_kubeapps_deploy_filename=${SSH_KEY_KUBEAPPS_DEPLOY_FILENAME}" >> $GITHUB_OUTPUT echo "ssh_key_forked_charts_deploy_filename=${SSH_KEY_FORKED_CHARTS_DEPLOY_FILENAME}" >> $GITHUB_OUTPUT diff --git a/.github/workflows/kubeapps-release.yml b/.github/workflows/kubeapps-release.yml index 73d73aef35a..715f3ecfa53 100644 --- a/.github/workflows/kubeapps-release.yml +++ b/.github/workflows/kubeapps-release.yml @@ -8,6 +8,7 @@ on: push: tags: - 'v[0-9]+.[0-9]+.[0-9]+' + # TODO(bjesus) Remove the following line once we have tested the release process - 'test-.*' concurrency: From ba52bc681f4437c0007577cac16b0d6c6a5d6c2e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jes=C3=BAs=20Benito=20Calzada?= Date: Fri, 11 Nov 2022 07:30:41 +0100 Subject: [PATCH 3/3] Fix lint issues MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Jesús Benito Calzada --- .github/workflows/kubeapps-general.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/kubeapps-general.yaml b/.github/workflows/kubeapps-general.yaml index 55accc3bdef..efb825a9fe8 100644 --- a/.github/workflows/kubeapps-general.yaml +++ b/.github/workflows/kubeapps-general.yaml @@ -138,7 +138,7 @@ jobs: else echo "running_on_tag=false" >> $GITHUB_OUTPUT fi - + # TODO(bjesus) Once we've properly tested the release job, we can/should remove this hack, just leave the content from the else branch if [[ ${GITHUB_REF_TYPE} == "tag" && ${GITHUB_REF_NAME} == 'test-'* ]]; then echo "DEV_MODE=true" >> $GITHUB_ENV @@ -146,7 +146,7 @@ jobs: else echo "dev_mode=${DEV_MODE}" >> $GITHUB_OUTPUT fi - + echo "golang_version=${GOLANG_VERSION}" >> $GITHUB_OUTPUT echo "ssh_key_kubeapps_deploy_filename=${SSH_KEY_KUBEAPPS_DEPLOY_FILENAME}" >> $GITHUB_OUTPUT echo "ssh_key_forked_charts_deploy_filename=${SSH_KEY_FORKED_CHARTS_DEPLOY_FILENAME}" >> $GITHUB_OUTPUT