Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Heatmap Attribute Data Scaling (#312) #316

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Luke-Schreiber
Copy link
Contributor

@Luke-Schreiber Luke-Schreiber commented Feb 27, 2025

Does this PR close any open issues?

Closes #312

Give a longer description of what this PR addresses and why it's needed

Issue #312: Datapoints were scattered out-of-bounds in 'additional attribute' columns which contain violin plots

This PR:

  • Changes the datapoint scaling from static domains to dynamic data-based domains.
  • Ensures that all violin plots and datapoints (within each additional attribute) internally have the same horizontal scaling.

Provide pictures/videos of the behavior before and after these changes (optional)

Before:
415358392-8511c9eb-36d0-44ef-b3d0-14896e750269

After:
312

Have you added or updated relevant tests?

  • Yes
  • No changes are needed

Have you added or updated relevant documentation?

  • Yes
  • No changes are needed

Are there any additional TODOs before this PR is ready to go?

TODOs:

  • ...

@Luke-Schreiber Luke-Schreiber self-assigned this Feb 27, 2025
@Luke-Schreiber Luke-Schreiber linked an issue Feb 27, 2025 that may be closed by this pull request
2 tasks
@Luke-Schreiber Luke-Schreiber changed the title Bugfix/312 heatmap attribute data scaling Fix: heatmap attribute data scaling Feb 27, 2025
@Luke-Schreiber Luke-Schreiber changed the title Fix: heatmap attribute data scaling Fix: heatmap attribute data scaling (#312) Feb 27, 2025
@Luke-Schreiber Luke-Schreiber changed the title Fix: heatmap attribute data scaling (#312) Fix: Heatmap Attribute Data Scaling (#312) Feb 27, 2025
Copy link
Member

@JackWilb JackWilb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets simplify

Co-authored-by: Jack Wilburn <jackwilburn@tutanota.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heatmap's additional attribute datapoints escape boundary
2 participants