-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lang/zh.js file from build #1878
Comments
Interesting. I don't know why that would still be in the dist. There's no zh.json in the lang folder. There must be something with our language build step. @seniorflexdeveloper can you tell what might be going on here (since you originally put together the grunt task)? |
It's in the dist: /~https://github.com/videojs/video.js/tree/v4.12.0/dist/video-js/lang |
...that's probably what it was
|
@heff - I'm not sure what language that is. It's definitely not in our standard array. Also the grunt task just normalizes the JSON -> JS process and src/dest locations. |
Yeah, I think the issue here is that we need to add a step in the dist process that clears out any existing files. |
According to latest changes in language files I suggest remove zh.js file from build because he not needed anymore.
PS! For more info see PRs #1729 and #1841
The text was updated successfully, but these errors were encountered: