Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get canonical id from group resource #44

Closed
wants to merge 1 commit into from

Conversation

gopisaba
Copy link

Description of your changes

This PR adds option to reference the Group resource to get canonical id to create Group Alias.

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Signed-off-by: Gopinath Sabapathy <gopisaba@users.noreply.github.com>
@gopisaba
Copy link
Author

@ulucinar / @sergenyalcin - I don't know how to test it locally. I tried both make run and make reviewable test both unable to find the targets in Makefile. Could you please help?

@gopisaba gopisaba closed this Oct 16, 2024
@gopisaba gopisaba deleted the CanonicalIDFromGroupRef branch October 16, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant